Skip to content

Fix view button dropdown not showing iin front. #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkbula merged 2 commits into from
May 14, 2026
Merged

Fix view button dropdown not showing iin front. #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
227f337
Fix view button dropdown not showing iin front.
himsin May 11, 2026
42ea370
Replaced useEffect with a handleToggle() function that computes posit…
himsin May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 34 additions & 10 deletions src/components/ViewSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { useState, useRef, useCallback } from 'react'
import { createPortal } from 'react-dom'
import { Save, Trash2, Pencil, Check, X, Eye } from 'lucide-react'
import type { CustomView, CustomViewsStorage } from '../types/views'
import { useClickOutside } from '../hooks/useClickOutside'

interface ViewSelectorProps {
views: CustomViewsStorage
Expand All @@ -27,13 +27,20 @@ export function ViewSelector({
const [newName, setNewName] = useState('')
const [editingId, setEditingId] = useState<string | null>(null)
const [editName, setEditName] = useState('')
const ref = useRef<HTMLDivElement>(null)
const [pos, setPos] = useState<{ top: number; right: number } | null>(null)
const buttonRef = useRef<HTMLButtonElement>(null)
const closeDropdown = useCallback(() => {
setOpen(false)
setSaveAsMode(false)
setEditingId(null)
}, [])
useClickOutside(ref, closeDropdown)

function handleToggle() {
if (open) { setOpen(false); return }
const rect = buttonRef.current?.getBoundingClientRect()
if (rect) setPos({ top: rect.bottom, right: window.innerWidth - rect.right })
setOpen(true)
}

const activeView = views.activeViewId ? views.views.find((v) => v.id === views.activeViewId) : null

Expand Down Expand Up @@ -62,9 +69,10 @@ export function ViewSelector({
const displayName = activeView?.name ?? 'View'

return (
<div ref={ref} className="relative flex items-center">
<div className="relative flex items-center">
<button
onClick={() => setOpen(!open)}
ref={buttonRef}
onClick={handleToggle}
title={activeView?.name ?? 'Default View'}
className="flex items-center gap-1.5 px-2 py-1 rounded transition-all duration-150"
style={{
Expand All @@ -90,11 +98,23 @@ export function ViewSelector({
</button>
)}

{open && (
<div
className="absolute top-full left-0 mt-1 min-w-[200px] max-h-[400px] overflow-auto rounded border shadow-xl z-[100]"
style={{ backgroundColor: 'var(--bg-tertiary)', borderColor: 'var(--border)' }}
>
{open && pos && createPortal(
<>
<div
onMouseDown={closeDropdown}
style={{ position: 'fixed', inset: 0, zIndex: 99 }}
/>
<div
className="min-w-[200px] max-h-[400px] overflow-auto rounded border shadow-xl"
style={{
position: 'fixed',
top: pos.top + 4,
right: pos.right,
zIndex: 100,
backgroundColor: 'var(--bg-tertiary)',
borderColor: 'var(--border)',
}}
>
<button
onClick={() => {
onViewSelect(null)
Expand Down Expand Up @@ -241,7 +261,11 @@ export function ViewSelector({
</button>
)}
</div>
</>,
document.body,
)}
</div>
)
}


Loading