Skip to content

feat: add Windows ARM64 architecture support #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkdir700 merged 1 commit into from
Sep 13, 2025
Merged

feat: add Windows ARM64 architecture support #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,11 @@ win:
- target: nsis
arch:
- x64
- arm64
- target: portable
arch:
- x64
- arm64
signtoolOptions:
Comment on lines 65 to 68
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Windows Portable: arm64 added — LGTM; naming is consistent.

Artifact naming already includes ${arch}; no changes needed. If you don’t intend to distribute portable builds via auto-update, ensure release notes/documentation reflect that only NSIS supports updates on Windows.

🤖 Prompt for AI Agents 
In electron-builder.yml around lines 65 to 68, you added arm64 to the Windows
portable arch list which is fine; no build config changes are required, but if
you do not plan to distribute portable (portable/zip) builds via auto-update,
update the project release notes and documentation to explicitly state that only
the NSIS installer supports auto-updates on Windows and that portable artifacts
will not be auto-updated, so consumers and release automation are aware of the
limitation.

sign: scripts/win-sign.js
verifyUpdateCodeSignature: false
Expand Down
Loading