Skip to content

C89 happy.#18

Open
ssrlive wants to merge 12 commits intomkirchner:masterfrom
ssrlive:c89
Open

C89 happy.#18
ssrlive wants to merge 12 commits intomkirchner:masterfrom
ssrlive:c89

Conversation

@ssrlive
Copy link
Copy Markdown
Contributor

@ssrlive ssrlive commented Dec 23, 2019

I have changed the code to fit C89 standard. Please review it. Hope you can merge it. Thanks.

@ssrlive
Copy link
Copy Markdown
Contributor Author

ssrlive commented Dec 23, 2019

When I changed all malloc call to calloc call, the make command will pass successfully, but CMake will keep failed with Heap allocation referenced from stack should be tagged.

@ganesh-k13
Copy link
Copy Markdown
Contributor

Hi @ssrlive , I am facing same problem with gcc over clang, see #17,

@ssrlive ssrlive changed the title c89 happy. C89 happy. Jan 2, 2020
@ssrlive
Copy link
Copy Markdown
Contributor Author

ssrlive commented Feb 23, 2020

Hi @mkirchner, I hope you merge this changes. Thanks.

@ssrlive ssrlive requested a review from mkirchner February 23, 2020 04:00
@mkirchner
Copy link
Copy Markdown
Owner

Hi @ssrlive, this is C99 compatible; what is the reason to downgrade to C89?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants