Skip to content

Testing linters #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkolosek wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Testing linters #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e82e18c
Testing linters
mkolosek Nov 28, 2018
82d9e29
Additional linter error
mkolosek Nov 29, 2018
9187b52
Additional linter error
mkolosek Nov 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/controllers/pages_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
class PagesController < ApplicationController
def welcome

puts 'this should not be here'

@sniffler sniffler Nov 29, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/ExtraSpacing: Unnecessary spacing detected.
Layout/SpaceBeforeFirstArg: Put one space between the method name and the first argument.

puts 'This is a very long line. This is a very long line. This is a very long line. This is a very long line. This is a very long line. This is a very long line. This is a very long line. This is a very long line. '

@sniffler sniffler Nov 29, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/IndentationConsistency: Inconsistent indentation detected.
Metrics/LineLength: Line is too long. [222/80]

puts 'Inconsistent spacing.....'

@sniffler sniffler Dec 4, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/ExtraSpacing: Unnecessary spacing detected.
Layout/SpaceBeforeFirstArg: Put one space between the method name and the first argument.


puts 'This is a very long line. This is a very long line. This is a very long line. This is a very long line. This is a very long line. This is a very long line. This is a very long line. This is a very long line. '

@sniffler sniffler Dec 4, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [219/80]



@sniffler sniffler Dec 4, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/EmptyLines: Extra blank line detected.
Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.

end

end