Add metadata to exported functions#3855
Open
eyupcanakman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2410. Exported
.mlxfnfiles can now store a metadata dictionary, so a model's config can live with the function instead of in a separate JSON file.export_functionandexportertake an optionalmetadataargument, a dict of string keys to string, int, or float values.import_function(file, return_metadata=True)returns the function along with that dict, mirroringload(..., return_metadata=True)for safetensors and gguf. The value shape follows the one suggested in the issue.Integer and float values are stored as 64-bit so a Python int or float round-trips without narrowing. Metadata is only supported when exporting to a file. Passing it with a callback raises.
The metadata lives in the file header, so a
.mlxfnwritten before this change has no metadata section and won't load in a metadata-aware build. That matches the existing note that exported functions aren't compatible across MLX versions.