Prioritize rlnMicrographPreExposure for tilt order#456
Open
ryanfeathers wants to merge 3 commits intomainfrom
Open
Prioritize rlnMicrographPreExposure for tilt order#456ryanfeathers wants to merge 3 commits intomainfrom
ryanfeathers wants to merge 3 commits intomainfrom
Conversation
rish-raghu
requested changes
Aug 29, 2025
| if self.preexposure is not None: | ||
| sort_idxs = self.preexposure[ind].argsort() | ||
| else: | ||
| sort_idxs = self.ctfscalefactor[ind].argsort() |
Contributor
There was a problem hiding this comment.
Can we add a stable=True here? The scale factor cannot distinguish between symmetric tilts, e.g. -3 and +3, but by doing a stable sort, we can at least preserve tilt ordering that is already sorted, instead of making it random.
Contributor
Author
There was a problem hiding this comment.
Good call! I think they should be sorted by exposure order either from Warp or RELION5 so that makes the most sense. Sort by ctfscalefactor is the current default behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.