This commit updates the msgpack / sentencepiece submodules #92
Conversation
There was an issue building mlc-llm from source with newer CMAKE versions (specifically 4.1.2). This is due to removal of compatibility with CMAKE features below 3.5. The underlying repositories had already been bumped by maintainers, so this is a basic bump. For msgpack, I updated to the latest `master-cpp` branch, and for sentencepiece, i bumped to master. I've tested by building mlc-llm from source using this version of tokenizers-cpp, and it worked with no issues.
Summary of ChangesHello @babusid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical build failure encountered when compiling Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the msgpack and sentencepiece submodules to resolve a build issue with newer CMake versions. The changes are straightforward submodule commit bumps. While the updates fix the immediate problem, my review suggests pinning the submodules to specific release tags instead of branch heads (like master or master-cpp) to improve long-term stability and reproducibility of the build. This is a common best practice for managing dependencies.
There was an issue building mlc-llm from source with newer CMAKE versions (specifically 4.1.2). This is due to removal of compatibility with CMAKE features below 3.5. The underlying repositories had already been bumped by maintainers, so this is a basic bump. For msgpack, I updated to the latest
master-cppbranch, and for sentencepiece, i bumped to master.I've tested by building mlc-llm from source using this version of tokenizers-cpp, and it worked with no issues.