Merge Dev#219
Open
arjunsuresh wants to merge 22 commits into
Open
Conversation
* Update repo_action.py to force index rebuild when a new repo is pulled * Update AI PR review workflow by adding fetch step for PR head * Update index.py to incrementally add and remove index entries of a repo
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
🤖 AI PR Review Summary\n\nThis PR adds a new 'reindex' command to the mlc Action class to allow explicit reindexing of scripts, caches, experiments, or all targets. It enhances the Index class to better handle index rebuilding, including removal of deleted items and improved modified time tracking. New tests are added to the CI workflow to verify reindexing behavior and index consistency after manual deletion of indexed items. The changes improve index robustness and provide explicit control over reindexing. Risks include potential performance impact due to full index rebuilds on reindex commands and the partial implementation of per-target reindexing (currently all targets are rebuilt regardless of target). The index rebuild logic is complex and may require further testing to ensure no regressions in index consistency. |
🤖 AI PR Review Summary\n\nThis PR adds a new GitHub Actions workflow to test the MLCFlow installer script across multiple OS environments and scenarios using both native runners and Docker containers. It also updates the AI PR review workflow to fetch the PR base ref and PR head SHA for incremental diffs. The new test workflow is comprehensive, covering various OS versions, installation modes, and validation steps. Risks include potential increased CI usage and complexity in maintaining the large test matrix. Design-wise, the workflow is well-structured with clear validation and outcome verification steps, but the concurrency cancellation setting may cause loss of intermediate test results. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
🤖 AI PR Review Summary\n\nThis PR introduces enhancements to the GitHub Actions workflows by refining the incremental PR diff workflow and adding a comprehensive new workflow to test the MLCFlow installer script across multiple OS environments and scenarios. The new test-installer-curl.yml workflow covers native runners and Docker containers, testing various installation scenarios including basic install, quiet mode, upgrade mode, and custom virtual environment directories. It validates installation success by checking expected artifacts and CLI functionality. Risks include increased CI runtime and complexity, potential flakiness in curl-pipe installation tests, and the concurrency setting which may cancel in-progress runs and lose intermediate results. The design is thorough and well-structured but could benefit from clearer documentation on concurrency trade-offs and potential fallback strategies for flaky tests. |
🤖 AI PR Review Summary\n\nThis PR adds a new comprehensive GitHub Actions workflow to test the MLCFlow installer script across multiple OS environments and scenarios using both native runners and Docker containers. It also improves the existing AI PR review workflow by fetching the PR base ref and PR head commit explicitly. The new test workflow runs the installer via the exact curl-pipe method users will use, validates installation artifacts, and verifies expected outcomes. Risks include increased CI resource usage due to the large matrix and potential flakiness from network-dependent curl-pipe installation. Design is robust with detailed validation steps and concurrency control, but the hardcoded branch name in workflow_dispatch event and some commented considerations on concurrency behavior may need review. |
🤖 AI PR Review Summary\n\nThis PR adds a new comprehensive GitHub Actions workflow to test the MLCFlow installer script across multiple OS environments and scenarios, including native runners and Docker containers. It also updates the existing AI PR review workflow to fetch the PR base ref and PR head commit explicitly. The new test workflow is extensive, covering various OS versions, installation modes, and validation steps. Risks include increased CI runtime and complexity, potential flakiness in curl-pipe installer tests, and the concurrency cancellation possibly hiding intermediate failures. Design-wise, the test matrix is well-structured and thorough, but hardcoded branch names and some commented-out code may need cleanup. |
🤖 AI PR Review Summary\n\nThis PR adds a new comprehensive GitHub Actions workflow to test the MLCFlow installer script across multiple OS environments and scenarios using both native runners and Docker containers. It also updates the existing AI PR review workflow to fetch the PR base ref and PR head commit explicitly. The new test workflow is extensive, covering various OS versions, installation modes, and validation steps. Risks include increased CI runtime and complexity, potential flakiness due to network-dependent curl-pipe installation, and the concurrency setting that may cancel in-progress runs, possibly losing intermediate test results. Design-wise, the workflow is well-structured with clear matrix definitions and validation steps, but the hardcoded branch in workflow_dispatch and some commented-out options could be improved for flexibility. |
🤖 AI PR Review Summary\n\nThis PR adds a new comprehensive GitHub Actions workflow to test the MLCFlow installer script across multiple OS environments and scenarios using both native runners and Docker containers. It also improves the existing AI PR review workflow by ensuring the checkout uses the PR base ref and fetches the PR head commit explicitly. The new test workflow runs the installer via the exact curl-pipe method users will use, validates installation artifacts, and verifies expected outcomes. Risks include increased CI resource usage due to the extensive test matrix and potential flakiness in curl-pipe execution. Design is robust with concurrency controls and detailed validation steps, but the hardcoded branch in workflow_dispatch event and some commented notes suggest areas for future refinement. |
* Added script meta validation support * Improve error handling * Update meta_schema.py
🤖 AI PR Review Summary\n\nThis PR adds a new GitHub Actions workflow to test the MLCFlow installer script across multiple OS environments and scenarios, including native runners and Docker containers. It also updates the existing AI PR review workflow to fetch the PR base ref and PR head SHA for incremental diffs. The new test workflow is comprehensive, covering various OS versions, installation flags, and validation steps to ensure the installer works as expected. Risks include increased CI runtime and complexity, potential flakiness in curl-pipe installation tests, and the concurrency setting which may cancel in-progress runs and lose intermediate failure data. Design-wise, the test matrix is well-structured, but the hardcoded branch name in workflow_dispatch could cause confusion or stale tests if not updated. |
* Update VERSION
🤖 AI PR Review Summary\n\nThis PR adds and updates several GitHub Actions workflows including an incremental diff fetch improvement, CLA allowlist update, a new code formatting workflow using autopep8, and a comprehensive new installer test workflow that tests the MLCFlow installer script across multiple OSes and scenarios. The main risks involve the complexity and maintenance overhead of the large installer test workflow, potential token and permission issues in the formatting workflow, and ensuring the incremental diff fetch correctly targets the base ref. Design-wise, the workflows are well-structured but the installer test workflow is very large and could benefit from modularization or splitting into smaller files for maintainability. |
anandhu-eng
approved these changes
Apr 15, 2026
BarnacleBob
approved these changes
Apr 15, 2026
🤖 AI PR Review Summary\n\nThis PR adds and updates multiple GitHub Actions workflows to improve CI automation. It modifies the AI PR review workflow to fetch the PR base ref and head SHA explicitly, updates the CLA workflow allowlist, introduces a new code formatting workflow using autopep8, and adds a comprehensive installer test workflow that runs installation tests on multiple OS environments and scenarios. The main risks involve potential CI failures due to environment or script changes, and the complexity of the new installer test workflow which may require maintenance. Design-wise, the workflows are well-structured but some hardcoded values and concurrency settings may need review. |
* Improvements to GH actions * Version upgrade * mlc version support added * Support mlc apptainer script
🤖 AI PR Review Summary\n\nThis PR updates multiple GitHub Actions workflows primarily by pinning action versions to specific commit SHAs for reproducibility and stability. It introduces a new code formatting workflow that automatically formats Python files on push events, and adds a comprehensive new workflow to test the MLCFlow installer script across various OS and scenarios. The changes reduce risks related to action version drift but introduce complexity in the new formatting and installer test workflows. Careful monitoring is needed to ensure the new workflows do not cause unexpected CI failures or excessive resource usage. |
🤖 AI PR Review Summary\n\nThis PR updates multiple GitHub Actions workflows by pinning action versions to specific commit SHAs for improved stability and reproducibility. It introduces a new code formatting workflow that automatically formats Python files on push, and adds a comprehensive new workflow to test the MLCFlow installer script across multiple OS and scenarios. The changes modernize CI/CD pipelines but introduce risks related to the new formatting workflow's automatic commits and the complexity of the large installer test workflow. Careful monitoring is needed to ensure no unintended side effects occur, especially with the new formatting automation and concurrency cancellation behavior. |
* To add missing exception handling for meta file in repo_action.py * Update index entry deletion function to remove duplicates by both path and UID
🤖 AI PR Review Summary\n\nThis PR updates multiple GitHub Actions workflows by pinning action versions to specific commit SHAs for improved stability and reproducibility. It adds a new code formatting workflow that automatically formats Python files on push events, and introduces a comprehensive new workflow to test the MLCFlow installer script across multiple OS and scenarios. Minor improvements include adding permissions where missing and fixing deprecated set-output commands. Risks include potential workflow failures if pinned SHAs become incompatible or unavailable, and the new formatting workflow might cause unexpected commits if not carefully monitored. The installer test workflow is large and complex, which may increase CI resource usage and maintenance burden. |
🤖 AI PR Review Summary\n\nThis PR updates multiple GitHub Actions workflows by pinning action versions to specific commits for improved stability and reproducibility. It also introduces a new workflow for automatic code formatting and adds a comprehensive test workflow for the MLCFlow installer using curl. The changes include migration from deprecated set-output commands to the new GITHUB_OUTPUT file for setting outputs. Risks include potential breaking changes from pinned action versions and the complexity of the new installer test workflow, which may require maintenance. Design-wise, the workflows improve security and reliability but should be monitored for compatibility with future GitHub Actions updates. |
🤖 AI PR Review Summary\n\nThis PR updates multiple GitHub Actions workflows by pinning action versions to specific commit SHAs for improved stability and reproducibility. It introduces a new workflow for automatic Python code formatting using autopep8, triggered on all branch pushes except those by the automation bot. The PR also adds a comprehensive new workflow to test the MLCFlow installer script on various OS and scenarios using curl and bash, improving CI coverage for installation validation. Minor improvements include adding permissions to workflows and refining environment variable usage. Risks include potential workflow failures if pinned SHAs become invalid or incompatible with future GitHub Actions changes. The new formatting workflow may cause unexpected commits if autopep8 modifies files, and the installer test workflow is large and complex, which could increase CI runtime and maintenance burden. |
🤖 AI PR Review Summary\n\nThis PR updates multiple GitHub Actions workflows by pinning action versions to specific commits for improved stability and reproducibility. It adds a new formatting workflow to automatically format Python files on push events, and introduces a comprehensive installer test workflow to validate the MLCFlow installer across multiple OS and scenarios. Minor improvements include fixing deprecated set-output commands and adding permissions where missing. Risks include potential workflow failures if pinned commits become incompatible or removed, and the new formatting workflow may cause unexpected commits if not properly reviewed. The installer test workflow is large and complex, increasing maintenance burden. |
* Update pyproject.toml * Update VERSION
🤖 AI PR Review Summary\n\nThis PR updates multiple GitHub Actions workflows by pinning action versions to specific commits for improved stability and reproducibility. It introduces a new code formatting workflow that automatically formats Python files on push events, and adds a comprehensive installer test workflow that validates the MLCFlow installer across multiple OS and scenarios. Minor improvements include adding permissions where missing and refining environment variable usage. Risks include potential workflow failures if pinned commits become incompatible or removed, and the new formatting workflow might cause unexpected commits if not carefully monitored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ PR Checklist
dev📌 Note: PRs must be raised against
dev. Do not commit directly tomain.✅ Testing & CI
📚 Documentation
📁 File Hygiene & Output Handling
🛡️ Safety & Security
🙌 Contribution Hygiene
Fixes #orCloses #.