type safe for getShape1D and getShape2D

[jobo322]

No description provided.

[codecov]

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.36%. Comparing base (1377ac1) to head (4e34be7).

Files with missing lines	Patch %	Lines
src/shapes/2d/getShape2D.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   93.18%   96.36%   +3.18%     
==========================================
  Files          23       23              
  Lines         968      963       -5     
  Branches      206      213       +7     
==========================================
+ Hits          902      928      +26     
+ Misses         65       34      -31     
  Partials        1        1              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[targos]

refactor: replace exponentiation with multiplication for performance improvement i

Do you have a benchmark to prove this?

[jobo322]

refactor: replace exponentiation with multiplication for performance improvement i

Do you have a benchmark to prove this?

right, I just read it, but I run a mitata benchmark and the difference is almost noise. let me revert this change

[jobo322]

@targos is it correct the refactoring of getShape1D? the idea is that typescript know that the returned shape instance has the corresponding instance type instead of an union type. to improve the type safe in the dependents packages like spectra-fitting

[targos]

It's OK, but I pushed a simplification to avoid all the workarounds