Skip to content

feat!: optimize parameters on demand by optimize flag#117

Merged
jobo322 merged 7 commits into
mainfrom
optimize-on-demand-859-27-2026
May 5, 2026
Merged

feat!: optimize parameters on demand by optimize flag#117
jobo322 merged 7 commits into
mainfrom
optimize-on-demand-859-27-2026

Conversation

@jobo322
Copy link
Copy Markdown
Member

@jobo322 jobo322 commented Apr 27, 2026

remove the baseline option and internally rescale the y data with absolute max value to 1 in

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2c29c4e) to head (d780053).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #117      +/-   ##
===========================================
+ Coverage   95.22%   100.00%   +4.77%     
===========================================
  Files           7         9       +2     
  Lines         314       424     +110     
  Branches       62        91      +29     
===========================================
+ Hits          299       424     +125     
+ Misses         15         0      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jobo322 jobo322 requested a review from targos May 4, 2026 15:49
@jobo322
Copy link
Copy Markdown
Member Author

jobo322 commented May 4, 2026

@targos, the last commit is a breaking changes and it is focus on fix an issue with the optimization of lorentzian shape parameters. do you prefer to split it into another PR?

@jobo322 jobo322 changed the title feat: optimize parameters on demand by optimize flag feat!: optimize parameters on demand by optimize flag May 4, 2026
@targos
Copy link
Copy Markdown
Member

targos commented May 5, 2026

It would have been better to split (think about it in the future) but I can review the changes separately here.

@jobo322 jobo322 merged commit f45ee0a into main May 5, 2026
11 checks passed
@jobo322 jobo322 deleted the optimize-on-demand-859-27-2026 branch May 5, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants