Skip to content

fix(release): use conventionalcommits preset#74

Merged
spawnia merged 1 commit intomasterfrom
use-conventionalcommits-preset
Feb 27, 2026
Merged

fix(release): use conventionalcommits preset#74
spawnia merged 1 commit intomasterfrom
use-conventionalcommits-preset

Conversation

@simbig
Copy link
Contributor

@simbig simbig commented Feb 27, 2026

Summary

Why

The angular preset does not recognize the ! breaking change indicator in commit subjects (e.g., feat!:). It only looks for BREAKING CHANGE: in the commit footer. The conventionalcommits preset supports both, which matches what the project documents in CLAUDE.md.

This caused the release workflow to skip releasing after #72 merged.

Test plan

The angular preset (default) does not recognize the `!` breaking change
indicator in commit subjects like `feat!:`. Switch to the
conventionalcommits preset which supports both `!` and
`BREAKING CHANGE:` footer.

BREAKING CHANGE: Illumina sample sheet V2 API was redesigned in the previous commit for NovaSeq X and cloud support
@simbig simbig requested a review from spawnia February 27, 2026 13:39
@spawnia spawnia merged commit 96519b7 into master Feb 27, 2026
29 checks passed
@spawnia spawnia deleted the use-conventionalcommits-preset branch February 27, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants