Skip to content

Add Ghostscript to persistent package list for ImageMagick#1304

Open
Teko012 wants to merge 4 commits into
mlocati:masterfrom
Teko012:add-ghostscript
Open

Add Ghostscript to persistent package list for ImageMagick#1304
Teko012 wants to merge 4 commits into
mlocati:masterfrom
Teko012:add-ghostscript

Conversation

@Teko012

@Teko012 Teko012 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

This pull request makes a small update to the install-php-extensions script to improve dependency handling for ImageMagick extensions.

  • Added ghostscript to the list of persistent required packages when installing ImageMagick-related PHP extensions, ensuring better compatibility and support for image processing features.

The Alpine variant already has it, but it's missing on Debian. It is required for PDF handling.

@mlocati

mlocati commented Jun 10, 2026

Copy link
Copy Markdown
Owner

How big is ghostscript?

@Teko012

Teko012 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@mlocati On Alpine, which the script already installs, it's 62.9MiB. The one we add for Debian now is 57.5 MB.

@mlocati

mlocati commented Jun 10, 2026

Copy link
Copy Markdown
Owner

Do you have a small PHP script that can be used to test whether imagick works correctly with PDF files?

@Teko012

Teko012 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@mlocati I added a script. The test seems to have failed due to some unrelated Docker issue, but the relevant part has passed. Maybe you can rerun the failed ones, they should pass too.

@Teko012

Teko012 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@mlocati Can we merge this in? It might cause a merge conflict with #1306, which I would need to fix

Comment thread scripts/tests/imagick
'BMP' => true,
'GIF' => true,
'JPG' => true,
'PDF' => false,

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed testing the case when imagick supports reading a format, but doesn't support writing it (eg when the value is false).
For example, we previously had 'PDF' => false, meaning that imagick was listed in the result of Imagick::queryFormats().

Also, please don't be so verbose in comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants