Add Ghostscript to persistent package list for ImageMagick#1304
Add Ghostscript to persistent package list for ImageMagick#1304Teko012 wants to merge 4 commits into
Conversation
|
How big is ghostscript? |
|
@mlocati On Alpine, which the script already installs, it's 62.9MiB. The one we add for Debian now is 57.5 MB. |
|
Do you have a small PHP script that can be used to test whether imagick works correctly with PDF files? |
Test: imagick
Test: imagick
|
@mlocati I added a script. The test seems to have failed due to some unrelated Docker issue, but the relevant part has passed. Maybe you can rerun the failed ones, they should pass too. |
| 'BMP' => true, | ||
| 'GIF' => true, | ||
| 'JPG' => true, | ||
| 'PDF' => false, |
There was a problem hiding this comment.
You removed testing the case when imagick supports reading a format, but doesn't support writing it (eg when the value is false).
For example, we previously had 'PDF' => false, meaning that imagick was listed in the result of Imagick::queryFormats().
Also, please don't be so verbose in comments.
This pull request makes a small update to the
install-php-extensionsscript to improve dependency handling for ImageMagick extensions.ghostscriptto the list of persistent required packages when installing ImageMagick-related PHP extensions, ensuring better compatibility and support for image processing features.The Alpine variant already has it, but it's missing on Debian. It is required for PDF handling.