Add Decoder::getTXTRecordFromDomain()#40
Merged
mlocati merged 3 commits intomlocati:mainfrom Jun 23, 2025
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
============================================
+ Coverage 92.74% 92.76% +0.02%
- Complexity 662 664 +2
============================================
Files 44 44
Lines 1598 1603 +5
============================================
+ Hits 1482 1487 +5
Misses 116 116
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
@BrandonXLF I've updated this PR with 4da1fd5 |
Owner
|
Thanks! I've just published version 3.3.0 with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves SPF TXT record finding functionality to its function,
getTXTRecordFromDomain.For my project, I would like to have access to the raw DNS text record to show to users whenever possible. Currently, this is not possible since TXT record finding happens within
getRecordFromDomain, so it's impossible to access the raw TXT record outside of that function.With the PR, the following is possible: