Skip to content

[FIX] Pin sidebar button disappears when project search dropdown is opened#3712

Merged
pini-sh-panda merged 1 commit into
mlrun:developmentfrom
amit-noy:ML-12815
Jun 30, 2026
Merged

[FIX] Pin sidebar button disappears when project search dropdown is opened#3712
pini-sh-panda merged 1 commit into
mlrun:developmentfrom
amit-noy:ML-12815

Conversation

@amit-noy

@amit-noy amit-noy commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

📝 Description

When opening the project search dropdown, the pin sidebar button would disappear. The dropdown content renders as a Radix portal outside the sidebar nav, causing the mouse-leave event to remove the CSS
group-hover state that keeps the pin button visible.


🛠️ Changes Made

  • Added a CSS :has() rule in tailwind.css that keeps the pin button visible while the project dropdown trigger has data-state="open"

✅ Checklist

  • I have given the PR a well-structured title describing the domain and the specific change that was made
  • I tested the changes in the browser (locally or via preview build)
  • I confirmed that existing tests pass
  • I added or updated unit / integration tests (if needed)
  • I checked that this change doesn’t introduce new console warnings or lint / formatting errors
  • I updated the relevant Jira ticket with the appropriate details and status

🔗 References


🚨 Potentially Breaking Changes

  • Yes
  • No

Includes DRC change

  • Yes
  • No

If yes -> requires bump NPM version


🔍 Additional Notes


📸 Screenshots / Demos


@amit-noy amit-noy requested a review from pini-sh-panda June 28, 2026 16:04
Comment thread src/tailwind.css
padding: 0;
}
}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amit-noy not best practice to use data-testid.

@pini-sh-panda pini-sh-panda merged commit 55c0030 into mlrun:development Jun 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants