[FEAT] [UI] Internalize igz-controls from dashboard-react-controls#3713
Open
arturrybalskyy-dev wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Moves all used
dashboard-react-controls(DRC) components, hooks, utils, constants, types, styles, and images intoui/src/igz-controls/and redirects the existingigz-controlsVite alias fromnode_modulesto the local path.This removes the
iguazio.dashboard-react-controlsnpm dependency entirely. All 391 source files that import fromigz-controls/...require zero changes - the alias preservation strategy ensures full backwards compatibility.🛠️ Changes Made
ui/src/igz-controls/- full local copy of all used DRC entities (components, hooks, utils, constants, types, scss, fonts, images, nextGenComponents)vite.config.mjsandvitest.config.mjs- redirectedigz-controlsalias fromnode_modules/iguazio.dashboard-react-controls/disttosrc/igz-controls/jsconfig.jsonandtsconfig.json- added matching path mappings for IDE resolutionpackage.json- removediguazio.dashboard-react-controlsdependency; removednli/nuiscripts that installed/updated DRCeslint.config.mjs- addedsrc/igz-controls/nextGenComponents/**to ignores (TypeScript files requiring TS-aware parser).github/workflows/ci.yaml- updated error hint to referenceui/src/igz-controls/instead of the removed npm packagesrc/igz-controls/index.scss—-replaces the formerdist/index.cssglobal stylesheet bundle✅ Checklist
🔗 References
🚨 Potentially Breaking Changes
Includes DRC change
🔍 Additional Notes
ChipFormcomponent andproxyServerConfigutil were intentionally excluded per task requirement ("Do not move unused entities")