[FIX] Add missing owner domain in Applications → API Gateways#3714
Open
amit-noy wants to merge 2 commits into
Open
[FIX] Add missing owner domain in Applications → API Gateways#3714amit-noy wants to merge 2 commits into
amit-noy wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
The owner field in the Applications → API Gateways tab was displaying only the username instead of the full
username@domainformat. The domain is stored in a separate Nuclio label (iguazio.com/domain) that was not being read.The fix also extends to
enrichFunctionsWithNuclio, which feeds the owner field on the Applications list and Overview tab, and to the owner filter so it matches against the full composed string.🛠️ Changes Made
buildNuclioOwner(labels)tonuclioEnrichment.util.js— composesusername@domainfromiguazio.com/usernameandiguazio.com/domainNuclio labelsapiGatewaysColumns.jsxowner column to usebuildNuclioOwnerfilterApiGatewaysBySearchFieldsto filter against the full composed owner string (supports searching by domain)enrichFunctionsWithNuclioto usebuildNuclioOwnerso the Applications list and Overview tab also display the correct owner✅ Checklist
🔗 References
🚨 Potentially Breaking Changes
Includes DRC change
If yes -> requires bump NPM version
🔍 Additional Notes
📸 Screenshots / Demos