chore: pin lumid-hooks<0.2.0 until reconcile() impls land#56
Open
tjluyao wants to merge 1 commit into
Open
Conversation
lumid-hooks 0.2.0 (0f5e3df) added a breaking ResourceRegistrar.reconcile method to the Protocol. The example plugins under examples/plugins/simple_plugin implement only register/deregister, so a fresh `uv sync` against the upstream floor would pull 0.2.0 and break mypy on the examples. Production deployments are unaffected — requirements.txt was already pinned to ==0.1.0 in src/server/requirements.txt and src/worker/requirements/*.txt. This change tightens the pyproject.toml floor + hook/pyproject.toml floor to match, so dev installs stay in sync with prod until the examples are updated to satisfy the new Protocol. Signed-off-by: Yao Lu <fdyaolu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lumid-hooks 0.2.0 (commit 0f5e3df, "BREAKING feat: add ResourceRegistrar.reconcile") adds a required
reconcile(resources, logger)method to theResourceRegistrarProtocol. The example plugins underexamples/plugins/simple_plugin/registrar.pyimplement onlyregister+deregister, so a freshuv syncagainst the upstream floor (lumid-hooks>=0.1.0) would pull 0.2.0 and break mypy on the examples.Production deployments are unaffected —
src/server/requirements.txt+src/worker/requirements/*.txtwere already pinned tolumid-hooks==0.1.0, so the server image doesn't shift. This PR tightens thepyproject.toml+hook/pyproject.tomlfloor to match, keeping dev installs in sync with prod until the examples are updated to satisfy the new Protocol.Changes
pyproject.toml:lumid-hooks>=0.1.0→lumid-hooks>=0.1.0,<0.2.0hook/pyproject.toml: sameuv.lock: regenerated (no version drift; lumid-hooks stays at 0.1.0)src/server/requirements.txt+ worker requirements: unchanged (already pinned to 0.1.0)When to drop this pin
Once
examples/plugins/simple_plugin/registrar.py(and any other in-repoResourceRegistrarimplementers) adds areconcile()method, drop the upper bound and bump tolumid-hooks>=0.2.0.Test plan
uv lock— clean re-resolutionuv run scripts/dev/sync_requirements.py --write— no diff on requirements files🤖 Generated with Claude Code