Removed TODO comments and implemented missing logic in PlanScheduler #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mlsysops ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…iscard logic - Added MECHANISM_TYPE mapping for singleton vs multi-instance mechanisms - Implemented discard logic for conflicting mechanisms and inactive applications - Replaced TODOs in PlanScheduler with concrete logic - Added is_plan_app_active() helper in MLSState - Improved logging clarity for scheduled and discarded plans Signed-off-by: Pravin Kamble <iampbkamble@gmail.com>
p-r-a-v-i-n
force-pushed
the
fix/complete-todos
branch
from
604009e to
c85e2d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Question
I added this mapping for mechanism types:
MECHANISM_TYPE = { "cpu_freq": "singleton", "component_placement": "multi" }Are these mechanism names and their types correct, or do we need to update/add more?