feat: add mlconnector container build in CI #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anastassios Nanos <ananos@nubificus.co.uk> Signed-off-by: Alexandros Patras <patras@uth.gr>
Signed-off-by: Alexandros Patras <patras@uth.gr>
✅ Deploy Preview for mlsysops ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ananos
requested changes
Aug 7, 2025
Contributor
ananos
left a comment
ananos
left a comment
There was a problem hiding this comment.
thanks @alexanpatr. Only minor nits + an extra file. Remove it and we can merge!
| @@ -0,0 +1,179 @@ | |||
| name: Build agent containers | |||
Contributor
There was a problem hiding this comment.
I suspect this is a typo, should read: build ML connector
| runs-on: ${{ format('{0}-{1}', 'base-dind-2204', matrix.arch) }} | ||
| strategy: | ||
| matrix: | ||
| arch: ["arm64", "amd64"] |
Contributor
There was a problem hiding this comment.
Does ML connector have support for arm64? or (more accurately) do we plan to deploy the ML connector on arm64 devices? If yes, we can keep that -- otherwise no reason to build the container image.
Contributor
There was a problem hiding this comment.
seems like a former file in conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.