Skip to content

fix: Feature grouping and Java language support (#140, #143, #146)#147

Open
mmorris35 wants to merge 6 commits intomainfrom
fix/feature-grouping-146
Open

fix: Feature grouping and Java language support (#140, #143, #146)#147
mmorris35 wants to merge 6 commits intomainfrom
fix/feature-grouping-146

Conversation

@mmorris35
Copy link
Owner

Summary

Fixes the regression from the previous PR and the root cause of the Java/.txt issue.

#146 - Feature grouping over-corrects (REGRESSION)

  • Root cause: groupRelatedFeatures only pushed groups when they had items (endpoints)
  • Fix: Now pushes ALL groups - features without endpoints are preserved as separate phases
  • Features 1-7 now appear correctly, with endpoints grouped under last feature before them

#140 - Plan scaffold generates .txt paths for Java

  • Root cause: TemplateKey.language type only included 6 languages (python, typescript, javascript, go, rust, unknown)
  • When detectLanguage returned "java", switch statement fell through to "unknown"
  • getLanguageDefaults("unknown") returned .txt extension
  • Fix: Added java, kotlin, csharp, ruby, swift, cpp, zig to TemplateKey.language
  • Updated switch statement to handle all detected languages properly

#143 - Endpoints as separate phases

Testing

  • wrangler deploy --dry-run passes

Remaining Issues

Closes #140, #143, #146

#146 - Feature grouping over-corrects (REGRESSION)
- Fixed groupRelatedFeatures to push ALL groups, not just those with items
- Features without endpoints are now preserved as separate phases

#140 - Plan scaffold generates .txt paths for Java
- Root cause: TemplateKey.language was a separate restricted type from DetectedLanguage
- Fix: TemplateKey.language now reuses DetectedLanguage type directly
- No more manual switch mapping - detected language passes through
- Adding new languages only requires updating DetectedLanguage + LANGUAGE_DEFAULTS

#143 - Endpoints as separate phases
- Fixed by #146 - endpoints now grouped with preceding feature
@mmorris35 mmorris35 force-pushed the fix/feature-grouping-146 branch from d88a97c to 3d44439 Compare February 14, 2026 01:53
Radarr O'Really added 5 commits February 13, 2026 17:54
- Deploy to staging on push to fix/* and feat/* branches
- Deploy to staging on PRs to main
- Deploy to production only on push to main
- Add PR comment with staging URL for testing
Staging environment was being redirected to production custom domain.
Added ENVIRONMENT check to skip redirect when ENVIRONMENT=staging.
Haiku agent only sees the current context and can't reference CLAUDE.md.
Added COMPLETION_INSTRUCTION constant that gets inserted after each
subtask's Completion Notes section, telling the agent exactly how to
mark the subtask as complete.

Closes #148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Plan scaffold generates nonsensical file paths (.txt extension, Python naming for Java)

1 participant