fix: Feature grouping and Java language support (#140, #143, #146)#147
Open
fix: Feature grouping and Java language support (#140, #143, #146)#147
Conversation
#146 - Feature grouping over-corrects (REGRESSION) - Fixed groupRelatedFeatures to push ALL groups, not just those with items - Features without endpoints are now preserved as separate phases #140 - Plan scaffold generates .txt paths for Java - Root cause: TemplateKey.language was a separate restricted type from DetectedLanguage - Fix: TemplateKey.language now reuses DetectedLanguage type directly - No more manual switch mapping - detected language passes through - Adding new languages only requires updating DetectedLanguage + LANGUAGE_DEFAULTS #143 - Endpoints as separate phases - Fixed by #146 - endpoints now grouped with preceding feature
d88a97c to
3d44439
Compare
added 5 commits
February 13, 2026 17:54
- Deploy to staging on push to fix/* and feat/* branches - Deploy to staging on PRs to main - Deploy to production only on push to main - Add PR comment with staging URL for testing
Staging environment was being redirected to production custom domain. Added ENVIRONMENT check to skip redirect when ENVIRONMENT=staging.
Haiku agent only sees the current context and can't reference CLAUDE.md. Added COMPLETION_INSTRUCTION constant that gets inserted after each subtask's Completion Notes section, telling the agent exactly how to mark the subtask as complete. Closes #148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the regression from the previous PR and the root cause of the Java/.txt issue.
#146 - Feature grouping over-corrects (REGRESSION)
groupRelatedFeaturesonly pushed groups when they had items (endpoints)#140 - Plan scaffold generates .txt paths for Java
TemplateKey.languagetype only included 6 languages (python, typescript, javascript, go, rust, unknown)detectLanguagereturned "java", switch statement fell through to "unknown"getLanguageDefaults("unknown")returned.txtextension#143 - Endpoints as separate phases
Testing
wrangler deploy --dry-runpassesRemaining Issues
Closes #140, #143, #146