Skip to content

fix: Tree conversion breaking when LC_NUMERIC not standard "C".#515

Open
Advueu963 wants to merge 3 commits intomainfrom
tree_conversion-fix
Open

fix: Tree conversion breaking when LC_NUMERIC not standard "C".#515
Advueu963 wants to merge 3 commits intomainfrom
tree_conversion-fix

Conversation

@Advueu963
Copy link
Copy Markdown
Collaborator

Motivation and Context

Fix Tree conversion problems due to LC_NUMERIC not set to standard C, but de_DE. As such the conversion library did not correctly parse the XGBoost/LightGBM model.

Public API Changes

  • No Public API changes
  • Yes, Public API changes (Details below)

How Has This Been Tested?

We have added new tests, to check that the conversion works correclty.

Checklist

  • The changes have been tested locally.
  • Documentation has been updated (if the public API or usage changes).
  • An entry has been added to CHANGELOG.md (if relevant for users).
  • The code follows the project's style guidelines.
  • I have considered the impact of these changes on the public API.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants