fix: respect autoAppLaunch config option in test fixture#110
Open
farhanlabib wants to merge 1 commit into
Open
fix: respect autoAppLaunch config option in test fixture#110farhanlabib wants to merge 1 commit into
farhanlabib wants to merge 1 commit into
Conversation
8e5ffba to
a609c89
Compare
The autoAppLaunch config option was already honoured by the launcher (installAndLaunchApps), but the @mobilewright/test fixture ignored it and always terminated + relaunched the app before every test whenever bundleId was set. This adds autoAppLaunch as a proper fixture option (read from config, overridable per-test) and guards the terminate/launch block so that setting autoAppLaunch: false skips the relaunch — leaving the app in whatever state it is already in.
a609c89 to
9e5db37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
autoAppLaunch: falseinmobilewright.configwas silently ignored by the@mobilewright/testfixture. Even with the option set, the fixture always calledterminateApp+launchAppbefore every test wheneverbundleIdwas configured.The option was only respected in the launcher path (
installAndLaunchApps), not in the test fixture.Fix
autoAppLaunchas a proper fixture option (reads from config, overridable per-test — consistent with howbundleIdworks)devicefixtureautoAppLaunch !== falseBehaviour
bundleIdset, noautoAppLaunchbundleIdset,autoAppLaunch: truebundleIdset,autoAppLaunch: falseUse case
Useful for development workflows and test suites where the app is already in the foreground and a cold restart is undesirable (e.g. preserving session state, faster iteration).