Terminate transport child on terminate#40
Open
rockneurotiko wants to merge 1 commit intomobileoverlord:masterfrom
Open
Terminate transport child on terminate#40rockneurotiko wants to merge 1 commit intomobileoverlord:masterfrom
rockneurotiko wants to merge 1 commit intomobileoverlord:masterfrom
Conversation
Contributor
|
@rockneurotiko Justin has been away, so I figured that I'd led you know his plans before you put too much more time into I saw that you've sent multiple PRs. If you have any interest maintaining the project, please let Justin know. Once he gets back, that might be interesting to explore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves #39
On
:normalstop, the child processes are not terminated. Let's trap the Socket process exit and manually stop the transport child to avoid dangling processes.