Skip to content

Terminate transport child on terminate#40

Open
rockneurotiko wants to merge 1 commit intomobileoverlord:masterfrom
rockneurotiko:terminate_transport_process
Open

Terminate transport child on terminate#40
rockneurotiko wants to merge 1 commit intomobileoverlord:masterfrom
rockneurotiko:terminate_transport_process

Conversation

@rockneurotiko
Copy link
Copy Markdown

This PR solves #39

On :normal stop, the child processes are not terminated. Let's trap the Socket process exit and manually stop the transport child to avoid dangling processes.

@fhunleth
Copy link
Copy Markdown
Contributor

fhunleth commented Mar 1, 2021

@rockneurotiko Justin has been away, so I figured that I'd led you know his plans before you put too much more time into phoenix_client. phoenix_client was originally written to support Nerves use cases, but it hasn't been a project that anyone on the Nerves core team has had any time or interest maintaining. I suspect the project will eventually be archived or maybe just live on with all issues/PRs ignored. We're looking at replacing all Nerves uses with https://github.com/NFIBrokerage/slipstream which is both actively maintained and fixes issues.

I saw that you've sent multiple PRs. If you have any interest maintaining the project, please let Justin know. Once he gets back, that might be interesting to explore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants