Open
Conversation
migrate dependencies to toml file [version catalog] migrate gradle files to kotlin script
network security config is only available from api 24+
redundant as was only used in retrofit, which has it embedded
- Capture error messages directly from ResponseBody in Retrofit calls - Ensure error messages are correctly assigned to Throwable.message - Adjust safeApiCall to properly propagate error messages
- Simplifies using `fold` - Handle cases more concisely - Log exceptions only in `onFailure` block
abstracts retrofit and okhttp builders
adds ROOM as persistence for Users migrates source of truth to local datasource adds internet connection responsiveness adds auto-sync
adds image for case user list is empty and no internet extracts contact screen title from list for persistence
# Conflicts: # feature/contacts/src/test/kotlin/com/picpay/desafio/android/feature/contacts/viewmodel/ContactsScreenViewModelTest.kt
# Conflicts: # feature/contacts/src/test/kotlin/com/picpay/desafio/android/feature/contacts/viewmodel/ContactsScreenViewModelTest.kt
desafio_2024
abstracts LocalUserFlowUseCase into interface and impl
adds FakeLocalUsersFlowUseCase adds extra type dependency to contacts module test
desafio_2024
# Conflicts: # gradle.properties
remove code smell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.