Build ZIP extension, improve Dockerfile#3
Open
wrobelda wants to merge 2 commits intomobtitude:masterfrom
Open
Conversation
wrobelda
force-pushed
the
zip_fixes
branch
3 times, most recently
from
4f4d177 to
444516b
Compare
Debian hooks in their official images, which this image is based on, already do that through their hooks, see: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/ https://github.com/moby/moby/blob/03e2923e42446dbb830c654d0eec323a0b4ef02a/contrib/mkimage/debootstrap#L82-L105
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installs libzip-dev package and a PHP ZIP extension. Also reduces Dockerfile redundancy.
Fixes #2