Skip to content

ci: pin actions by sha#10

Open
thaJeztah wants to merge 1 commit intomoby:mainfrom
thaJeztah:pin_actions
Open

ci: pin actions by sha#10
thaJeztah wants to merge 1 commit intomoby:mainfrom
thaJeztah:pin_actions

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

No description provided.

@thaJeztah thaJeztah marked this pull request as draft March 25, 2026 18:41
Copy link
Copy Markdown

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this (using sha or defining a complete specific version) feels like a totally unnecessary complication which will create extra noise.

Unless, of course, a specific action used tends to break often, or GHA is used for something very important and security-sensitive, like building an official release binary.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review March 25, 2026 18:53
@thaJeztah
Copy link
Copy Markdown
Member Author

Yeah, not a huge fan, but there's an ongoing number of incidents impacting supply chain security; trivvy was the first one (all tags been force pushed), but from that it moved to multiple other actions and dependencies; linking to a blog post, but there's various other posts you can find; https://www.docker.com/blog/trivy-supply-chain-compromise-what-docker-hub-users-should-know/

@kolyshkin
Copy link
Copy Markdown

Yeah, not a huge fan, but there's an ongoing number of incidents impacting supply chain security; trivvy was the first one (all tags been force pushed), but from that it moved to multiple other actions and dependencies; linking to a blog post, but there's various other posts you can find; https://www.docker.com/blog/trivy-supply-chain-compromise-what-docker-hub-users-should-know/

I understand that but AFAIK CI in this repo is not really part of supply chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants