Attempt using go mod vendor without creating go.mod#3045
Attempt using go mod vendor without creating go.mod#3045errordeveloper wants to merge 3 commits intomoby:masterfrom
go mod vendor without creating go.mod#3045Conversation
Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
| go 1.17 | ||
|
|
||
| require ( | ||
| code.cloudfoundry.org/clock v1.0.0 |
There was a problem hiding this comment.
did this one work with v1.0.0 ? I recalled they tagged 1.0.0 (without v prefix, and therefore go modules didn't see that as a release); https://github.com/cloudfoundry/clock/releases/tag/1.0.0
There was a problem hiding this comment.
They've made two tags actually 1.0.0 and v1.0.0: https://github.com/cloudfoundry/clock/tags
There was a problem hiding this comment.
oh 🤦 how did I miss that? Perhaps I'm confused with another repository
| github.com/container-storage-interface/spec v1.2.0 | ||
| github.com/coreos/etcd v3.3.25+incompatible | ||
| github.com/docker/distribution v2.7.1+incompatible | ||
| github.com/docker/docker v20.10.3-0.20210720110456-471fd2770977+incompatible |
There was a problem hiding this comment.
Haven't checked, so just a random comment; did you manually specify the same commits (and/or versions) for each of these, or just let go modules find versions? (I expect "some" will be upgraded through indirect dependencies, which we can't prevent, but as long as we're mostly at the same version, that would be great (and we can handle upgrades later where we see fit)
There was a problem hiding this comment.
I didn't specify anything, I put exact commands in commit messages...
| @@ -1,10 +0,0 @@ | |||
| #include <stdio.h> | |||
There was a problem hiding this comment.
Interesting that go modules discards c files here; wondering if that's gonna be an issue 🤔 (for these, it's probably fine, I think these are only used for integration tests in moby, so vndr may have just been overly cautious)
There was a problem hiding this comment.
Yes, I don't think these can be recognised by go build in any way...
Codecov Report
@@ Coverage Diff @@
## master #3045 +/- ##
==========================================
- Coverage 62.15% 62.15% -0.01%
==========================================
Files 155 155
Lines 24533 24533
==========================================
- Hits 15249 15248 -1
- Misses 7686 7689 +3
+ Partials 1598 1596 -2 |
|
closing this in favour of #3046 |
3 participants
No description provided.