Skip to content

go.mod: remove more replace rules #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 4 commits into from
Nov 23, 2022
+174 −726
Merged

go.mod: remove more replace rules #3094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31959ec
go.mod: remove replace for google.golang.org/grpc
thaJeztah Nov 23, 2022
6b37ed9
go.mod: remove replace for github.com/golang/protobuf
thaJeztah Nov 23, 2022
0ee75c8
go.mod: remove replace for google.golang.org/protobuf
thaJeztah Nov 23, 2022
8038b4a
go.mod: google.golang.org/genproto v0.0.0-20210821163610-241b8fcbd6c8
thaJeztah Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,21 @@ require (
golang.org/x/crypto v0.1.0
golang.org/x/net v0.1.0
golang.org/x/time v0.1.0
google.golang.org/grpc v1.40.0

// NOTE(dperny,cyli): there is some error handling, found in the
// (*firstSessionErrorTracker).SessionClosed method in node/node.go, which
// relies on string matching to handle x509 errors. between grpc versions 1.3.0
// and 1.7.5, the error string we were matching changed, breaking swarmkit.
// In 1.10.x, GRPC stopped surfacing those errors entirely, breaking swarmkit.
// In >=1.11, those errors were brought back but the string had changed again.
// After updating GRPC, if integration test failures occur, verify that the
// string matching there is correct.
//
// For details, see:
//
// - https://github.com/moby/swarmkit/commit/4343384f11737119c3fa1524da2cb2707c70e04a
// - https://github.com/moby/swarmkit/commit/8a2b6fd64944bcef8154ced28f90aeec6abfeb04
google.golang.org/grpc v1.41.0
)

require (
Expand Down Expand Up @@ -139,18 +153,3 @@ require (

// Removes etcd dependency
replace github.com/rexray/gocsi => github.com/dperny/gocsi v1.2.3-pre

// NOTE(dperny,cyli): there is some error handling, found in the
// (*firstSessionErrorTracker).SessionClosed method in node/node.go, which
// relies on string matching to handle x509 errors. between grpc versions 1.3.0
// and 1.7.5, the error string we were matching changed, breaking swarmkit.
// In 1.10.x, GRPC stopped surfacing those errors entirely, breaking swarmkit.
// In >=1.11, those errors were brought back but the string had changed again.
// After updating GRPC, if integration test failures occur, verify that the
// string matching there is correct.
replace (
github.com/golang/protobuf => github.com/golang/protobuf v1.5.2
google.golang.org/genproto => google.golang.org/genproto v0.0.0-20211118181313-81c1377c94b1
google.golang.org/grpc => google.golang.org/grpc v1.41.0
google.golang.org/protobuf => google.golang.org/protobuf v1.27.1
)
Loading