manager/allocator/cnmallocator: convert to new-style driver registration#3143
Merged
dperny merged 3 commits intomoby:masterfrom Jul 7, 2023
Merged
manager/allocator/cnmallocator: convert to new-style driver registration#3143dperny merged 3 commits intomoby:masterfrom
dperny merged 3 commits intomoby:masterfrom
Conversation
…054c (25.0-dev) full diff: moby/moby@75ee002...98d3da7 Signed-off-by: Cory Snider <csnider@mirantis.com>
This function was not using the DriverCallback interface, and only required the Registerer interface. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
The libnetwork driver registry and driver Init() functions were deprecated in moby/moby@28edc8e in favour of separate registries for network and IPAM drivers and Register() functions for the drivers. Refactor the network driver initializer list to be a map as the network types should be unique, and it allows IsBuiltInDriver() to run in O(1) time. The remote drivers are a special case as they dynamically register plugins with the driver registries when the plugins are initialized. As they are the only drivers which need a PluginGetter, register the remote drivers separately as a special case rather than trying to continue shoehorning them into initializers and initIPAMDrivers(). There is no "remote" network type. However, Swarmkit has accepted it as a valid network type ever since support for selectable network drivers was first added in 5507383. This is a bug, as attempting to create such a network would ultimately fail. Special-casing the remote network driver incidentally fixes the bug as it is no longer present in initializers, which is used as the source of truth for IsBuiltinDriver(). Signed-off-by: Cory Snider <csnider@mirantis.com>
corhere
force-pushed
the
refactor_initializers
branch
from
23ee78f to
7d1f657
Compare
Collaborator
Author
|
@thaJeztah @dperny PTAL |
thaJeztah
approved these changes
Jul 7, 2023
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
whoops wrong radio button
LGTM thus! 😂🤣
1 task
This was referenced Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libnetwork driver registry and driver
Init()functions were deprecated in moby/moby@28edc8e in favour of separate registries for network and IPAM drivers andRegister()functions for the drivers.Refactor the network driver initializer list to be a map as the network types should be unique, and it allows
IsBuiltInDriver()to run in O(1) time.The remote drivers are a special case as they dynamically register plugins with the driver registries when the plugins are initialized. As they are the only drivers which need a
PluginGetter, register the remote drivers separately as a special case rather than trying to continue shoehorning them intoinitializersandinitIPAMDrivers().There is no "remote" network type. However, Swarmkit has accepted it as a valid network type ever since support for selectable network drivers was first added in 5507383. This is a bug, as attempting to create such a network would ultimately fail. Special-casing the remote network driver incidentally fixes the bug as it is no longer present in initializers, which is used as the source of truth for
IsBuiltinDriver().- What I did
- How I did it
- How to test it
- Description for the changelog