Update rust toolchain to 2022-05-17#1209
Merged
celinval merged 6 commits intomodel-checking:mainfrom May 25, 2022
Merged
Conversation
Status: Compilation succeeds but regression fails due to new intrinsic. Relevant changes: - rust-lang/rust#95837 - rust-lang/rust#95562 - rust-lang/rust#96883
This new intrinsic is used in many different places in the standard library and it was failing some tests for vectors.
adpaco-aws
reviewed
May 20, 2022
Contributor
adpaco-aws
left a comment
adpaco-aws
left a comment
There was a problem hiding this comment.
Looks great! My main comment has to do with the order for checks in ptr_offset_from_unsigned, the rest are minor comments.
tests/kani/Intrinsics/PtrOffsetFromUnsigned/check_unsigned_ptr_offset_from.rs
Show resolved
Hide resolved
tests/expected/intrinsics/ptr_offset_from_unsigned/check_invariant_violation.rs
Show resolved
Hide resolved
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
adpaco-aws
reviewed
May 20, 2022
celinval
commented
May 21, 2022
- Fix order of checks. - Improve error message. - Add comments to the new tests.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Update rust toolchain to 2022-05-17 and fix issues related to the upgrade. Relevant changes to the toolchain:
sub_ptron pointers (theusizeversion ofoffset_from) rust-lang/rust#95837Resolved issues:
Resolves #1206
Call-outs:
I had to implement the new intrinsic ptr_offset_from_unsigned. This new intrinsic is used in many different places in the standard library and it was failing some tests for vectors.
The intrinsic implementation was introduced in the second commit of this PR.
Testing:
How is this change tested? New test + regression
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.