Update toolchain to nightly-2022-07-19#1399
Merged
celinval merged 5 commits intomodel-checking:mainfrom Jul 22, 2022
Merged
Conversation
This update required the following changes: - Add support to ProjectionElem::OpaqueCast - Add support to Rvalue::CopyForDeref - Add support to ConstValue::ZST - Rename debugging_opts to unstable_opts - Change to mem::uninit/zeroed validity checks - Change vecdeque harness due to std capacity check
zhassan-aws
approved these changes
Jul 21, 2022
Contributor
zhassan-aws
left a comment
zhassan-aws
left a comment
There was a problem hiding this comment.
Suggest adding a couple of references. Otherwise, looks good. Thanks!
| assert_eq!(int.size(), Size::ZERO); | ||
| self.codegen_fndef(*d, substs, span) | ||
| (Scalar::Int(..), ty::FnDef(..)) => { | ||
| unreachable!("ZST is no longer represented as a scalar") |
Contributor
There was a problem hiding this comment.
Add a comment that points to the rustc PR?
| "https://github.com/model-checking/kani/issues/541", | ||
| ) | ||
| } | ||
| Rvalue::CopyForDeref(place) => { |
Contributor
There was a problem hiding this comment.
Might be helpful to refer to the comment in rustc that mentions that at the codegen level, this is just a read: https://github.com/rust-lang/rust/blob/1673f1450eeaf4a5452e086db0fe2ae274a0144f/compiler/rustc_middle/src/mir/syntax.rs#L1055
adpaco-aws
reviewed
Jul 21, 2022
Co-authored-by: Adrian Palacios <73246657+adpaco-aws@users.noreply.github.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This update required the following changes:
debugging_optstounstable_optsrust-lang/rust#98975)Resolved issues:
Resolves #1366
Call-outs:
Testing:
How is this change tested? New tests + old tests
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.