Update tests & docs for new atomic intrinsics without ordering restrictions#1487
Merged
adpaco-aws merged 3 commits intomodel-checking:mainfrom Aug 11, 2022
Merged
Conversation
celinval
approved these changes
Aug 10, 2022
danielsn
approved these changes
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Restrictions on memory orderings for atomic compare-exchange intrinsics were lifted about a month ago (see #1340 for more details).
These new orderings were already supported, but not tested. This PR updates the corresponding tests, and updates the intrinsics table including all changes in #1340 as well.
Resolved issues:
Resolves #1344
Call-outs:
No changes to the tests for the stable versions of these intrinsics (i.e.,
compare_exchange) have been made because the compiler throws errors such as:Testing:
How is this change tested? Existing regression and adding more cases in related tests.
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.