Add --no-fail-fast to compiletest#2145
Merged
celinval merged 1 commit intomodel-checking:mainfrom Jan 23, 2023
Merged
Conversation
Compiletest behavior has changed to always failing fast after model-checking#2045. This PR introduces a `--no-fail-fast` flag to compiletest which will execute the entire suite regardless of failure. The regression script uses `--no-fail-fast` so all failures in a suite are printed as part of the CI.
adpaco-aws
reviewed
Jan 23, 2023
adpaco-aws
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Compiletest behavior has changed to always failing fast after #2045. This PR introduces a
--no-fail-fastflag to compiletest which will execute the entire suite regardless of failure.The regression script uses
--no-fail-fastso all failures in a suite are printed as part of the CI.Resolved issues:
Resolves #2144
Related RFC:
Call-outs:
Testing:
How is this change tested? Manually tested the default behavior. The regression uses the new flag.
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.