Avoid an unnecssary suffix to the goto filename#2472
Merged
zhassan-aws merged 1 commit intomodel-checking:mainfrom May 25, 2023
Merged
Avoid an unnecssary suffix to the goto filename#2472zhassan-aws merged 1 commit intomodel-checking:mainfrom
zhassan-aws merged 1 commit intomodel-checking:mainfrom
Conversation
celinval
approved these changes
May 25, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
With #2439, codegen now produces a separate goto file for each harness. Thus, adding a
.for-<harness-name>suffix to the name of each goto file is no longer necessary. This PR removes the appending of the.for-<harness-name>to avoid unnecessarily long filenames.Resolved issues:
Resolves #2468
Related RFC:
Optional #ISSUE-NUMBER.
Call-outs:
Testing:
How is this change tested? Added one test
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.