Fix std overrides when crate has extern std#2989
Merged
tautschnig merged 2 commits intomodel-checking:mainfrom Feb 5, 2024
Merged
Fix std overrides when crate has extern std#2989tautschnig merged 2 commits intomodel-checking:mainfrom
tautschnig merged 2 commits intomodel-checking:mainfrom
Conversation
I tried applying model-checking#2983 fix, however, this would require user to import `__kani_workaround_core_assert`. To fix that, I moved the definition to be under `kani` crate.
zhassan-aws
approved these changes
Feb 3, 2024
Contributor
zhassan-aws
left a comment
zhassan-aws
left a comment
There was a problem hiding this comment.
Awesome, thanks @celinval!
feliperodri
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried applying #2983 fix, however, this would require user to import
__kani_workaround_core_assert. To fix that, I moved the definition to be underkanicrate.I replaced the existing fixme test. Initially I didn't check we had one, and I created a second one which is simpler (no cargo needed) but that also includes other cases.
Resolves #2187
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.