Subtree Update Automation Fixes#250
Conversation
|
Thanks for the quick PR. Are you also planning to fix the first item in the issue? We shouldn't mark this PR as resolving the issue until it fixes both. |
|
Could you also incorporate these changes https://github.com/carolynzech/rust/tree/fix-subtree-bugs in this PR? (It skips the PR creations if they already exist, avoiding situations where we force push over commits that people have made to those PR branches since). |
|
It'd also be nice to automate updating the Kani version in |
Oh, we could actually easily get the Kani commit id from the first step in the automation, which works in the Kani repository anyway. |
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
carolynzech
left a comment
carolynzech
left a comment
There was a problem hiding this comment.
Can you update the PR description and title to document the changes you made?
carolynzech
changed the title
There was a problem hiding this comment.
Can you please make these changes, then I'll approve? Perhaps @tautschnig or @qinheping could review as well.
I have not tested these suggested changes locally; please run it on your fork to make sure I'm right :)
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
Co-authored-by: Carolyn Zech <cmzech@amazon.com>
|
I ran this fixed Subtree Update on my fork and see that:
|
0027317
This restores a fix from model-checking#250 that was deemed no longer necessary with the move to subtree split (in model-checking#270), but this proved to be wrong. (See model-checking@ab648fe for such an example of an unintended change.)
This restores a fix from #250 that was deemed no longer necessary with the move to subtree split (in #270), but this proved to be wrong. (See ab648fe for such an example of an unintended change.) By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses. Co-authored-by: thanhnguyen-aws <ntson@amazon.com>
3 participants
Improvements to the workflow to update the subtree:
Resolves #249
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.