fix(proxyFetch): extract method, headers, body from Request inputs#1223
Open
Will-hxw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix(proxyFetch): extract method, headers, body from Request inputs#1223Will-hxw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Will-hxw wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
When createProxyFetch() is called with a Request object instead of (url, init), the original implementation only forwarded request.url and dropped method, headers, and body. This caused proxy payloads to lose request semantics. Now extracts method, headers, and body from Request inputs, with init still able to override those values when provided. Fixes modelcontextprotocol#1207
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Issue #1207: createProxyFetch() only passes url when given a Request object, dropping method, headers, and body semantics.
Validation