Skip to content

docs: fill migration guide gaps surfaced by automated upgrade eval #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxisbey merged 2 commits into from
Apr 9, 2026
+235 −5

docs: address minor migration guide gaps from upgrade eval

409f98b
Select commit
Loading
Failed to load commit list.
Merged

docs: fill migration guide gaps surfaced by automated upgrade eval #2412

docs: address minor migration guide gaps from upgrade eval
409f98b
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 9, 2026 in 19m 58s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit docs/migration.md:600-626 Context generic migration loses LifespanContextT=None precision

Annotations

Check warning on line 626 in docs/migration.md

See this annotation in the file changed.

@claude claude / Claude Code Review

Context generic migration loses LifespanContextT=None precision 

The migration guide shows `Context[ServerSession, None]` → bare `Context`, but this silently changes `LifespanContextT` from `None` to `dict[str, Any]` for type-checker users. The type-accurate v2 equivalent of `Context[ServerSession, None]` is `Context[None]`, not bare `Context`.
View more details on Claude