[v1.x] Add Streamable HTTP request body limits - #3101
Merged
Claude / Claude Code Review
completed
Jul 16, 2026 in 8m 38s
Code review found 1 potential issue
Found 5 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | tests/server/fastmcp/test_server.py:1495-1501 |
Stale "pragma: no cover" on FastMCP.session_manager return |
Annotations
Check warning on line 1501 in tests/server/fastmcp/test_server.py
claude / Claude Code Review
Stale "pragma: no cover" on FastMCP.session_manager return
The new test `test_streamable_http_app_passes_the_configured_request_body_limit_to_its_manager` accesses `mcp.session_manager`, which makes the `# pragma: no cover` on the `return self._session_manager` line (src/mcp/server/fastmcp/server.py:280) stale — the line is now executed by the suite but still excluded from coverage measurement. Since this PR already removes newly-stale pragmas elsewhere (the `mock_receive` functions in test_streamable_http_manager.py), drop this one too; the None-check
Loading