Extract MCP::Annotations into a dedicated file
#224
+81
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves `MCP::Annotations` from lib/mcp.rb to lib/mcp/annotations.rb for better organization, following the pattern used for other classes such as `Tool::Annotations`. This PR also adds the missing `last_modified` attribute to `MCP::Annotations`: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-11-25/schema.ts#L1701-L1736 It also adds a `to_h` method for serialization and includes comprehensive test coverage. NOTE: This code is unused within the ruby-sdk repository, but it is kept for compatibility, as it may be used by users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR moves
MCP::Annotationsfrom lib/mcp.rb to lib/mcp/annotations.rb for better organization, following the pattern used for other classes such asTool::Annotations.This PR also adds the missing
last_modifiedattribute toMCP::Annotations: https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-11-25/schema.ts#L1701-L1736It also adds a
to_hmethod for serialization and includes comprehensive test coverage.How Has This Been Tested?
Added comprehensive tests to verify the fix and prevent regression.
Breaking Changes
None. This code is unused within the ruby-sdk repository, but it is kept for compatibility, as it may be used by users.
Types of changes
Checklist