fix(client/sse): release reader lock on disconnect to prevent ~50MB leak#1961
Open
MukundaKatta wants to merge 2 commits intomodelcontextprotocol:v1.xfrom
Open
fix(client/sse): release reader lock on disconnect to prevent ~50MB leak#1961MukundaKatta wants to merge 2 commits intomodelcontextprotocol:v1.xfrom
MukundaKatta wants to merge 2 commits intomodelcontextprotocol:v1.xfrom
Conversation
🦋 Changeset detectedLatest commit: 06b2f9e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
_handleSseStream acquired a ReadableStream reader via getReader() but never called releaseLock() on either the success or error path. The upstream decoder + parser pipeline therefore stayed pinned across reconnects, leaking ~50MB per reconnect cycle for long-running clients. Wrap the read loop in try/finally so the lock is always released, then the outer catch can still schedule reconnection. Add a regression test in test/client/streamableHttp.test.ts that asserts releaseLock fires on both graceful close and error paths. Fixes modelcontextprotocol#1959.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1959.
_handleSseStreamacquired a reader viagetReader()but never calledreleaseLock()on disconnect, so the underlying stream and its buffered chunks (~50MB) stayed alive across reconnects. Wrapped the read loop in try/finally so the lock is always released, and added a regression test intest/client/streamableHttp.test.tsthat assertsreleaseLockfires on both graceful close and error paths.Note: I prepared this change via the GitHub API (no shell access to a local clone in this environment), so I could not run
pnpm testlocally. Happy to iterate if CI flags anything.