Pr/protocol overwriting transport hooks#477
Merged
ihrpr merged 1 commit intomodelcontextprotocol:mainfrom Jun 26, 2025
Merged
Conversation
nichtsam
force-pushed
the
pr/protocol-overwriting-transport-hooks
branch
from
2117e7b to
8e8e447
Compare
Contributor
Author
|
Just wanted to gently bring this back up. It’s a small fix. |
nichtsam
force-pushed
the
pr/protocol-overwriting-transport-hooks
branch
3 times, most recently
from
59359b1 to
e8931ac
Compare
nichtsam
force-pushed
the
pr/protocol-overwriting-transport-hooks
branch
from
e8931ac to
8b1a78c
Compare
nichtsam
force-pushed
the
pr/protocol-overwriting-transport-hooks
branch
from
8b1a78c to
9edb619
Compare
Contributor
Author
|
Hi @ihrpr, just bringing this PR back to attention in case it got buried. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Protocolclass currently hooks onto transports by completely overwriting them, which causes the originally hooked functions to be lost and not executed.For example this code snippet in the README.md wouldn't be executed.
https://github.com/modelcontextprotocol/typescript-sdk/blob/main/README.md?plain=1#L258-L262
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context