Add request init headers defined on the sse transport on the start phase#538
Merged
ihrpr merged 1 commit intomodelcontextprotocol:mainfrom May 27, 2025
Conversation
ihrpr
reviewed
May 27, 2025
| const tokens = await this._authProvider.tokens(); | ||
| if (tokens) { | ||
| headers["Authorization"] = `Bearer ${tokens.access_token}`; | ||
| (headers as Record<string, string>)["Authorization"] = `Bearer ${tokens.access_token}`; |
Contributor
There was a problem hiding this comment.
with this change, like 217 can be simplified as well:
const headers = new Headers({ ...commonHeaders, ...this._requestInit?.headers });
ihrpr
approved these changes
May 27, 2025
Contributor
ihrpr
left a comment
ihrpr
left a comment
There was a problem hiding this comment.
Thank you!
Minor suggestion can be addressed later.
|
hope we release this soon |
|
likewise, eager to get this into production! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr adds the headers from the transport instantiation into the start procedure to on sse(this already happens on the httpstream transport)
Motivation and Context
If i want to use sse transport and send a token for the authentication i need to have the token on the start phase
How Has This Been Tested?
This has been tested in a real application
Breaking Changes
I don't think there is breaking changes
Types of changes
Checklist
Additional context