Raw request propagation in tools - passed to callbacks via RequestHandlerExtra<ServerRequest, ServerNotification>#627
Merged
ihrpr merged 11 commits intomodelcontextprotocol:mainfrom Jun 25, 2025
Conversation
This was referenced Jun 13, 2025
Contributor
Author
Contributor
Author
|
Hello, let me know if anything else is needed on this PR. It's been waiting for a couple of weeks, have updated it with the latest from the branch. |
ihrpr
requested changes
Jun 24, 2025
Contributor
ihrpr
left a comment
There was a problem hiding this comment.
Sorry about the delays in review, we are trying to catch up SDK to the latest spec release. Thank you for implementing the suggestions.
Main concern is around onmessage from optional extra parameter to required, which breaks existing transport implementations that might not provide this parameter.
Contributor
Author
|
@ihrpr updated to reflect comments. |
ihrpr
reviewed
Jun 25, 2025
Contributor
ihrpr
left a comment
There was a problem hiding this comment.
thank you for the quick turnaround, left some inline comments
…ov/typescript-sdk into request-propagation-in-tools
Contributor
Author
These are done |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request Propagation to tool/resource/prompt callbacks via RequestHandlerExtra
This PR is a substitute of the original PR (#557).
Motivation and Context
An application often times needs access to the original request headers, for example, whenever it is sitting behind a reverse proxy, and the reverse proxy is setting some headers itself.
Few real-life examples / use cases:
How Has This Been Tested?
SSE and Streamable transport - resources and tools.
Breaking Changes
No breaking changes.
Types of changes
Checklist
Additional context
Adding the RequestInfo type, which contains just headers for now - to be used for more raw request properties to add as we go - e.g. httpMethod, and others.