[bugfix] fix gather_from_sp#63
Merged
Jintao-Huang merged 2 commits intomodelscope:mainfrom May 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request refines sequence parallel operations across several model files. Key updates include replacing reduce_scatter_to_sequence_parallel_region with scatter_to_sequence_parallel_region, which removes the need for manual scaling by the tensor model parallel size. Additionally, the gather_from_sequence_parallel_region calls now explicitly set tensor_parallel_output_grad=False, and forward passes in Qwen models are wrapped with a CUDA RNG tracker fork to ensure consistent randomness. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.