Skip to content

Fix ci#238

Merged
tastelikefeet merged 7 commits into
modelscope:mainfrom
tastelikefeet:fix/ci-1
Jun 30, 2026
Merged

Fix ci#238
tastelikefeet merged 7 commits into
modelscope:mainfrom
tastelikefeet:fix/ci-1

Conversation

@tastelikefeet

Copy link
Copy Markdown
Collaborator

PR type

  • Bug Fix
  • New Feature
  • Document Updates
  • More Models or Datasets Support

PR information

Write the detail information belongs to this PR.

Experiment results

Paste your experiment result here(if needed).

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI test script .dev_scripts/ci_container_test.sh by modifying the package installation targets to .[test,client,server] and pinning huggingface_hub<0.31 to avoid compatibility issues with PEP 604 union types. The review feedback highlights an inconsistency in the installation order between the conditional branches that could lead to dependency resolution issues, and suggests combining sequential pip install commands into single invocations to improve CI efficiency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .dev_scripts/ci_container_test.sh Outdated
Comment thread .dev_scripts/ci_container_test.sh Outdated
@tastelikefeet tastelikefeet merged commit a885c4e into modelscope:main Jun 30, 2026
2 of 3 checks passed
@tastelikefeet tastelikefeet deleted the fix/ci-1 branch June 30, 2026 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants