feat(opentui-solid,ui): add solidjs export#309
Conversation
…from bundle, and fix reactivity
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
|
Am I misinterpreting, but does this mean maintaining an internal solidjs fork going forward? Edit (after more than a passing glance): Okay, I guess it's not that bad. Just wondering how we can avoid drift between the React and Solid JS exports. |
- The @opentui/solid reconciler silently drops raw `fg` and `bg` props on TextNodeRenderable (span) elements which made the colours off when hunkdiff was embedded inside OpenCode.
- Replaced every `<span fg={...} bg={...}>` with `<span style={{ fg: ..., bg: ... }}>` in the opentui-solid export, since the Solid reconciler already handles `style` on text nodes correctly.
- When a diff file is created from a patch, the highlighter now receives the proper filetype (e.g. `typescript`, `javascript`) via `getFiletypeFromFileName` instead of defaulting to plain `"text"`, ensuring syntax tokens are generated.
Playing with hunkdiff internals for an opencode plugin.
Trying to embed
hunkdiffto render inside OpenCode's TUI via a custom route, backed by a new Solid OpenTUI component export.