Skip to content

fix(cli): validate surface add before session lookup#188

Merged
benvinegar merged 1 commit into
mainfrom
improve-cli-coverage
Jun 30, 2026
Merged

fix(cli): validate surface add before session lookup#188
benvinegar merged 1 commit into
mainfrom
improve-cli-coverage

Conversation

@benvinegar

@benvinegar benvinegar commented Jun 30, 2026

Copy link
Copy Markdown
Member

Summary

  • validate sideshow surface add has at least one surface flag before resolving/creating a session
  • resolve long-poll comment waits promptly when the client disconnects, avoiding lingering 60s waits in watch-style clients
  • expand CLI tests for trace publishing/syncing, top-level help/error handling, surface validation, and guide fallback behavior
  • isolate CLI test env from inherited SIDESHOW_* variables and harden watch test cleanup

Coverage impact

  • Overall line coverage: 93.94% → 95.03%
  • bin/sideshow.js line coverage: 81.72% → 87.29%
  • bin/sideshow.js branch coverage: 51.26% → 61.83%

Validation

  • node --test --test-name-pattern 'watch streams' test/cli.test.ts
  • node --test test/cli.test.ts
  • npm test
  • npm run typecheck
  • npm run lint
  • npm run format:check
  • npm run changeset:status -- --since=origin/main

Review

  • Ran fresh-context reviewer subagents twice.
  • Addressed initial review findings around misleading surface-add coverage, inherited env leakage, watch long-poll cleanup, and trace-sync quiet-mode assertions.
  • Final re-review found no blockers or major issues.

This PR description was generated by Pi using OpenAI GPT-5 Codex

@benvinegar benvinegar force-pushed the improve-cli-coverage branch from 6386fa5 to ab5ef86 Compare June 30, 2026 21:46
@benvinegar benvinegar changed the title test(cli): cover trace and error paths fix(cli): validate surface add before session lookup Jun 30, 2026
@benvinegar benvinegar merged commit ed8b987 into main Jun 30, 2026
9 checks passed
@benvinegar benvinegar deleted the improve-cli-coverage branch June 30, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant