Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
xelandernt
force-pushed
the
lazy_provider
branch
from
9330966 to
bb84b98
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new LazyProvider feature that enables lazy loading of providers through import strings, addressing circular dependency issues between containers. The main change removes the abc.ABC inheritance from SupportsContext to support proper multiple inheritance, and adds comprehensive implementation and testing of the lazy provider functionality.
- Implements
LazyProviderclass for lazy importing of providers using string-based references - Refactors
SupportsContextto removeabc.ABCinheritance and fixes MRO issues inBaseContainerMeta - Adds version constraint for faststream dependency
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| that_depends/providers/context_resources.py | Removes abc.ABC inheritance from SupportsContext to enable proper multiple inheritance |
| that_depends/meta.py | Reorders parent classes in BaseContainerMeta to fix MRO with updated SupportsContext |
| that_depends/experimental/providers.py | Implements new LazyProvider class with full provider protocol support |
| that_depends/experimental/init.py | Exports LazyProvider from experimental module |
| tests/experimental/test_lazy_provider.py | Adds validation tests for LazyProvider initialization |
| tests/experimental/test_container_2.py | Adds comprehensive integration tests for lazy provider functionality |
| tests/experimental/test_container_1.py | Adds circular dependency test case |
| pyproject.toml | Adds version constraint for faststream dependency |
| mkdocs.yml | Adds documentation navigation for lazy provider |
| docs/experimental/lazy.md | Adds user documentation for lazy provider feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
xelandernt
force-pushed
the
lazy_provider
branch
from
bb84b98 to
d17ba52
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #203