security(sql): validate SQL identifiers and queries to prevent injection#7699
Open
dfgvaetyj3456356-hash wants to merge 1 commit into
Open
Conversation
- Add _validate_select_query() to ensure wrapped queries start with SELECT and do not contain comment markers or statement terminators - Add _validate_sql_identifier() to ensure table names and partition columns contain only safe characters (alphanumeric + underscore) - Apply validation in column_names_query, row_count_query, partition_query - Apply validation in build_query_from_table and query_put_bounders - Raise InvalidQueryException or ValueError on validation failure
dfgvaetyj3456356-hash
requested review from
a team,
RehanSD,
YarShev,
anmyachev,
dchigarev,
devin-petersohn,
mvashishtha and
vnlitvinov
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies a security fix to validate SQL identifiers and queries to prevent injection attacks.